From: Giovanni Campagna <gcampagna@gnome.org>
Date: Sun, 8 Mar 2015 23:20:10 +0000 (-0700)
Subject: Search: be resilient against buggy search providers
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1515
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8b5a44e11924c3f572238955fb26120e3d5342ac;p=gnome-shell.git

Search: be resilient against buggy search providers

If a search provider returns a meta without a name, don't crash
constructing the actor.

https://bugzilla.gnome.org/show_bug.cgi?id=745861
---

diff --git a/js/ui/search.js b/js/ui/search.js
index 7e7cb83fa..e307ce3f8 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -205,6 +205,13 @@ const SearchResultsBase = new Lang.Class({
                     callback(false);
                     return;
                 }
+                if (metas.some(function(meta) {
+                    return !meta.name || !meta.id;
+                })) {
+                    log('Invalid result meta returned from search provider ' + this.provider.id);
+                    callback(false);
+                    return;
+                }
 
                 metasNeeded.forEach(Lang.bind(this, function(resultId, i) {
                     let meta = metas[i];